Repository navigation
Avoid leaking shovel status when a shovel is deleted before it successfully connects (in the starting state) - #16767
Merged
michaelklishin merged 1 commit intoJun 23, 2026
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
michaelklishin
added a commit
that referenced
this pull request
Jun 23, 2026
Avoid leaking shovel status when a shovel is deleted before it successfully connects (in the `starting` state) (backport #16767)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally discovered while working on something else.
The flaking test turned out to not be a flake but rather an annoying starting shovel deletion behavior
plus a fairly old
rabbitmq_shovel_managementtest that used AMQP 1.0 v1 addresses with AMQP 1.0 shovels, even though those addresses are disabled by default inmain.Therefore both the tests and the implementation had to be adapted.