Repository navigation
rabbitmq-plugins: tolerate plugins enabled but not installed - #16896
Merged
michaelklishin merged 2 commits intoJul 9, 2026
Merged
Conversation
shashank-singh-2999
requested review from
dumbbell,
michaelklishin and
mkuratczyk
and removed request for
michaelklishin
July 8, 2026 10:01
|
Tick the box to add this pull request to the merge queue (same as
|
michaelklishin
approved these changes
Jul 9, 2026
michaelklishin
deleted the
rabbitmq-plugins-tolerate-missing-enabled-plugins
branch
July 9, 2026 00:31
michaelklishin
added a commit
that referenced
this pull request
Jul 9, 2026
rabbitmq-plugins: tolerate plugins enabled but not installed (backport #16896)
michaelklishin
added a commit
that referenced
this pull request
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable/disablefail today ifenabled_pluginscontains a plugin that isn't installed (e.g. a discontinued plugin left over from before an upgrade), because both commands carry the existing enabled list, including the stale name, into the new list they write, and the write is rejected wholesale with{:plugins_not_found, [...]}. The only way out was editing the file by hand.Not specific to one plugin, see :- rabbitmq/rabbitmq-delayed-message-exchange#119
enable/disablenow keep such names in the file, warn about them the same waylistalready does, and proceed with the rest of the operation instead of failing.setis unchanged and still rejects unknown names, since it replaces the whole list explicitly.