Repository navigation
Quorum queues: skip decorator evalution for queues that do not have any - #17758
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Queue-leader caching and notification changes need runtime validation and final human review.
0 open findings
What changed in this PR
Reduces quorum queue processing overhead by skipping decorator evaluation for queues without decorators, aiming to improve publisher confirm latency.
Changes:
- Caches decorator presence and refreshes it on ticks, including for idle queues
- Adds regression coverage for caching and runtime decorator registration
- Uses a queue resource in the discard integration test
| File | Description |
|---|---|
deps/rabbit/test/rabbit_fifo_SUITE.erl |
Tests decorator caching and tick refresh |
deps/rabbit/test/rabbit_fifo_int_SUITE.erl |
Corrects the discard test’s queue resource |
deps/rabbit/test/quorum_queue_SUITE.erl |
Tests decorator notification on idle queues |
deps/rabbit/test/dummy_queue_decorator.erl |
Adds a test decorator |
deps/rabbit/src/rabbit_quorum_queue.erl |
Adds decorator-presence lookup |
deps/rabbit/src/rabbit_fifo.erl |
Caches decorator presence and skips unnecessary evaluation |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
michaelklishin
force-pushed
the
rabbitmq-server-17702
branch
from
October 8, 2026 05:00
8ded332 to
0a6304e
Compare
kjnilsson
approved these changes
Oct 8, 2026
michaelklishin
added a commit
that referenced
this pull request
Oct 8, 2026
Quorum queues: skip decorator evalution for queues that do not have any (backport #17758)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an efficiency improvement, both for CPU burn (runtime reductions) and publisher confirm latency, most notably the 95th and 99th percentiles.
The numbers reported in #17702 are reproducible
with this branch as well.
Close #17702.