Skip to content

Extract unit tests into separate workflow - #4472

Merged
ggivo merged 7 commits into
masterfrom
im/move-unit-tests-to-separate-workflow
Mar 26, 2026
Merged

ggivo merged 7 commits into
masterfrom
im/move-unit-tests-to-separate-workflow

Conversation

@uglide

@uglide uglide commented Mar 25, 2026 •

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Changes CI test execution by skipping unit tests in the main docker-based test action and relying on a new unit-tests.yml workflow instead; misconfiguration could reduce test coverage or change when failures surface.

Overview
Extracts Maven unit test execution into a dedicated GitHub Actions workflow (unit-tests.yml) that runs mvn ... test with JaCoCo reporting, publishes JUnit results, and uploads coverage to Codecov.

Updates the composite run-tests action to stop building Javadocs and to run verify with -DskipUnitTests=true (including for -Dtest=$TESTS runs), so the docker-based workflow focuses on non-unit test phases.

Cleans up noisy logging in EnvCondition by removing debug logs for the β€œenabled” paths while keeping disabled-reason logging.

Written by Cursor Bugbot for commit c74393e. This will update automatically on new commits. Configure here.

@jit-ci

jit-ci Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

πŸ›‘οΈ Jit Security Scan Results

CRITICAL HIGH MEDIUM

βœ… No security findings were detected in this PR


Security scan by Jit

@github-actions

github-actions Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

Test Results

β€‡β€ˆ173 files   -β€Šβ€‡β€ˆ135β€‚β€ƒβ€‡β€ˆ173 suites   -β€Š135   10m 53s ⏱️ - 1m 12s
8β€ˆ482 tests  -β€Š2β€ˆ654  7β€ˆ013 βœ…  -β€Š4β€ˆ067  1β€ˆ469 πŸ’€ +1β€ˆ413  0 ❌ Β±0 
3β€ˆ200 runsβ€Š  -β€Š2β€ˆ651  2β€ˆ712 βœ…  -β€Š3β€ˆ130β€‚β€ƒβ€‡β€ˆ488 πŸ’€ +β€‡β€ˆ479  0 ❌ Β±0 

Results for commit c74393e. ± Comparison against base commit 6d3ac4e.

This pull request removes 2655 and adds 1 tests. Note that renamed tests count towards both.
ALL_AVAILABLE Policy Tests ‑ shouldContinueWhenAllPending
ALL_AVAILABLE Policy Tests ‑ shouldContinueWhenPending
ALL_AVAILABLE Policy Tests ‑ shouldFailImmediatelyWithAnyFailure
ALL_AVAILABLE Policy Tests ‑ shouldFailWhenAllConnectionsFail
ALL_AVAILABLE Policy Tests ‑ shouldFailWhenAnyConnectionFails
ALL_AVAILABLE Policy Tests ‑ shouldFailWithEmptyContext
ALL_AVAILABLE Policy Tests ‑ shouldFailWithSingleFailure
ALL_AVAILABLE Policy Tests ‑ shouldSucceedWhenAllAvailable
ALL_AVAILABLE Policy Tests ‑ shouldSucceedWithSingleConnection
ConformsTo Policy Evaluation Tests ‑ shouldDelegateToPolicy
…
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)
This pull request removes 4 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
redis.clients.jedis.UdsTest ‑ jedisConnectsToUds
redis.clients.jedis.UdsTest ‑ jedisConnectsToUdsResp3
redis.clients.jedis.UdsTest ‑ unifiedJedisConnectsToUds
redis.clients.jedis.UdsTest ‑ unifiedJedisConnectsToUdsResp3
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)
This pull request skips 1416 tests.
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetdel
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetdelBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetexBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHsetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHsetexBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetdel
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetdelBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetexBinary
…

♻️ This comment has been updated with latest results.

Comment thread .github/workflows/unit-tests.yml Resolved
Comment thread .github/workflows/unit-tests.yml Resolved
@uglide
uglide requested a review from ggivo March 25, 2026 11:25
Comment thread .github/workflows/unit-tests.yml Resolved

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread .github/actions/run-tests/action.yml Resolved

@ggivo ggivo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggivo
ggivo merged commit 2174538 into master Mar 26, 2026
16 checks passed
@ggivo ggivo added the testing label May 27, 2026
@ggivo
ggivo deleted the im/move-unit-tests-to-separate-workflow branch September 30, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants