Repository navigation
Add support for FPHA argument with JSON.SET (Redis 8.8) - #4478
Merged
Merged
Conversation
atakavci
force-pushed
the
ali/json.set.fpha
branch
from
April 1, 2026 11:23
864ab73 to
8aea2f7
Compare
ggivo
reviewed
Apr 1, 2026
- add argument matcher methods
uglide
reviewed
Apr 24, 2026
β¦andObjectsJsonCommandsTest.java
uglide
requested changes
Apr 24, 2026
uglide
left a comment
Contributor
There was a problem hiding this comment.
Added integration tests are failing on 8.8
Co-authored-by: Igor Malinovskiy <u.glide@gmail.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 1e4c998. Configure here.
uglide
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Introducing FPHA argument into
JsonSetParams,enabling the use of storage type;
JSON.SET key path value [NX | XX] [FPHA BF16|FP16|FP32|FP64]FPHA BF16|FP16|FP32|FP64 - (FP Homogeneous Array) force Redis to use the specified FP type for storing all FP arrays in value.
See RedisJSON pr for more info.
Note
Low Risk
Additive support for a new RedisJSON argument with accompanying tests; low risk aside from potential incompatibility when used against Redis versions that donβt support
FPHA.Overview
Adds RedisJSON
JSON.SETsupport for the newFPHAargument (Redis 8.8+), exposingJsonSetParams.fp16(),bf16(),fp32(), andfp64()to force the floating-point array storage type.Updates protocol keywords to include
FPHA, switchesJsonSetParamsto useProtocol.Keywordconstants forNX/XX, and adds/extends tests (including version-gated parameterized coverage) to validate argument encoding and interactions. Also updatesCommandArgumentsMatcherswith a newcontainsArguments(...)helper and ensures the newJsonSetParamsTestis picked up by the formatter config.Reviewed by Cursor Bugbot for commit d288e11. Bugbot is set up for automated code reviews on this repo. Configure here.