💬 Trending Now: redis/jedis/pull/

uglide · 2026-04-16T09:03:35Z

Removes JedisPooled and JedisSentineled that have been replaced by RedisClient and RedisSentinelClient and removes deprecated UnifiedJedis constructors

JedisCluster is kept for compatibility with SDR 4.x

Note

Medium Risk
Removes public deprecated classes/constructors and rewires JedisCluster initialization, which can break downstream code that still referenced these APIs despite deprecations. Behavioral risk is moderate but mostly limited to construction paths and tests/docs updates.

Overview
Removes the deprecated JedisPooled and JedisSentineled classes, along with several deprecated UnifiedJedis public constructors, further consolidating client creation around RedisClient/RedisSentinelClient and builder-based configuration.

Updates JedisCluster constructors to explicitly construct a ClusterCommandExecutor/ClusterCommandObjects rather than delegating to now-removed UnifiedJedis cluster constructors, and adjusts builder defaults to reference RedisClusterClient.DEFAULT_MAX_ATTEMPTS.

Refreshes docs/tests to stop instantiating deprecated clients directly, including a new Advanced Usage section documenting Unix Domain Socket connections via a custom JedisSocketFactory + PooledConnectionProvider.

^{Reviewed by Cursor Bugbot for commit 0d4029d. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-04-16T09:05:32Z

Test Results

191 files ± 0 191 suites ±0 11m 37s ⏱️ -1s
9 221 tests + 6 9 003 ✅ +252 218 💤 - 246 0 ❌ ±0
3 461 runs +12 3 397 ✅ + 99 64 💤 - 87 0 ❌ ±0

Results for commit 0d4029d. ± Comparison against base commit 64c3e96.

This pull request removes 1 and adds 7 tests. Note that renamed tests count towards both.

redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)

redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[1]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[2]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[3]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[4]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[5]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[6]
redis.clients.jedis.commands.unified.search.FTHybridCommandsTestBase$SupportedScorersTest ‑ testScorer(Scorer, double, double)[7]

♻️ This comment has been updated with latest results.

jit-ci · 2026-04-16T09:05:58Z

🛡️ Jit Security Scan Results

✅ No security findings were detected in this PR

^{Security scan by Jit}

ggivo · 2026-04-16T13:29:17Z

  public void test() {
    ManagedConnectionProvider managed = new ManagedConnectionProvider();
-    try (UnifiedJedis jedis = new UnifiedJedis(managed)) {
+    try (UnifiedJedis jedis = new UnifiedJedis(managed, RedisProtocol.RESP2)) {


wondering if there is a reason for RESP2 explicitly

This PR removes UnifiedJedis(ConnectionProvider provider) constructor :)

ggivo · 2026-04-17T14:50:00Z

    // We want to be accurate about our mocks, hence we verify no more interactions here.
    // This might mean that some methods need to verify their interactions in a more verbose way,
    // but overall the benefit should be greater than the cost.
-    verify(connectionProvider).getConnection();


What is the reason for removing this verification step?

I've replaced usage of UnifiedJedis(CommandExecutor executor, ConnectionProvider provider, CommandObjects commandObjects) constructor with RedisClient builder above and we don't call the same code path anymore, so connection is no longer acquired from the ConnectionProvider to verify the RESP version.

ggivo · 2026-04-17T14:54:26Z

  public void unifiedJedisConnectsToUds() {
-    try (UnifiedJedis jedis = new UnifiedJedis(new UdsJedisSocketFactory())) {
+    try (UnifiedJedis jedis = new UnifiedJedis(new Connection(new UdsJedisSocketFactory()))) {
      assertEquals("PONG", jedis.ping());
    }
  }

  @Test
  public void unifiedJedisConnectsToUdsResp3() {
-    try (UnifiedJedis jedis = new UnifiedJedis(new UdsJedisSocketFactory(),
-        DefaultJedisClientConfig.builder().resp3().build())) {
+    try (UnifiedJedis jedis = new UnifiedJedis(new Connection(new UdsJedisSocketFactory(),
+        DefaultJedisClientConfig.builder().resp3().build()))) {
      assertEquals("PONG", jedis.ping());
    }


This made me think that we do not provide a documented migration path when using new clients via builders to configure/use a custom socket factory. For example, in this case, for using UDS sockets.

One option as a workaround, users can configure it on a connection provider and then use the factory to create a client with the connection provider.

Since we are also removing JedisPooled, we should document the workaround as a migration path or provide an OOB way to provide a custom socket factory

There is actually a similar discussion recently opened: #4477

I've added the documentation on how to use UDS with RedisClient

tishun

From the perspective of SDR : I've replaced the JEdis dependency with the one generated from this branch and there are 0 compilation errors and 0 test failures (including integration tests)

tishun · 2026-04-21T08:29:35Z

  @VisibleForTesting
  @Deprecated
-  public UnifiedJedis(CommandExecutor executor, ConnectionProvider provider, CommandObjects commandObjects) {
+  protected UnifiedJedis(CommandExecutor executor, ConnectionProvider provider, CommandObjects commandObjects) {


FWIW I would even go further and make it with package-private (default) visibility

For now, I think it's a safer choice to allow apps to use this constructor in their child classes as a workaround if needed.

…classes

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 0d4029d. Configure here.}

ggivo

LGTM

uglide requested review from ggivo and tishun April 16, 2026 09:03

uglide added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label Apr 16, 2026

uglide added this to the 8.0.0 milestone Apr 16, 2026

uglide added 3 commits April 16, 2026 11:29

Remove deprecated cluster constructors from the UnifiedJedis

37e61cd

Remove deprecated JedisSentineled

9a6a341

Remove deprecated JedisPooled

bd5bb35

uglide force-pushed the im/drop-deprecated-classes branch from 5f08848 to bd5bb35 Compare April 16, 2026 09:30

uglide added 2 commits April 16, 2026 11:49

Fix JedisCluster constructors

1e9b6cd

Remove more deprecated constructors from UnifiedJedis

0b345e3

uglide requested a review from atakavci April 16, 2026 10:25

uglide changed the title ~~Drop duplicating deprecated classes~~ Drop deprecated classes and constructors Apr 16, 2026

Remove UnifiedJedisConstructorReflectionTest which is no longer needed

bd2c57b

uglide mentioned this pull request Apr 16, 2026

Enable command retries for RedisClient and RedisSentinelClient by default #4490

Open

Merge branch 'master' into im/drop-deprecated-classes

64e48b5

ggivo reviewed Apr 17, 2026

View reviewed changes

tishun previously approved these changes Apr 21, 2026

View reviewed changes

uglide added 2 commits April 21, 2026 15:52

Merge remote-tracking branch 'origin/master' into im/drop-deprecated-…

49125f6

…classes

Fix javadoc for RedisClient

66bd013

uglide dismissed tishun’s stale review via 66bd013 April 21, 2026 14:02

uglide and others added 3 commits April 21, 2026 16:14

Remove redundant commandObjects setter on AbstractClientBuilder

20c8fca

Document UDS with RedisClient

e91ab03

Merge branch 'master' into im/drop-deprecated-classes

0d4029d

cursor Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread src/test/java/redis/clients/jedis/ManagedConnectionProviderTest.java Resolved

ggivo approved these changes Apr 21, 2026

View reviewed changes

uglide merged commit 9aac909 into master Apr 21, 2026
17 checks passed

uglide deleted the im/drop-deprecated-classes branch April 21, 2026 15:12

ggivo mentioned this pull request May 27, 2026

Follow up on : Add builders for classes based on UnifiedJedis #4301

Closed

Conversation

uglide commented Apr 16, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

jit-ci Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛡️ Jit Security Scan Results

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tishun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ggivo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

uglide commented Apr 16, 2026 •

edited by cursor Bot

Loading

github-actions Bot commented Apr 16, 2026 •

edited

Loading

jit-ci Bot commented Apr 16, 2026 •

edited

Loading