Repository navigation
test: fix flaky testPolicy_AllSuccess_StopsOnFirstFailure test - #4503
Merged
ggivo merged 2 commits intoApr 29, 2026
Merged
Conversation
using .interval(5) cause new health check to be scheduled before probes for existing one completes fix: use default healthcheck intercal 1s, giving time for probes to be performed
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
…opsOnFirstFailure
ggivo
deleted the
topic/ggivo/flaky-testPolicy_AllSuccess_StopsOnFirstFailure
branch
May 21, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test uses
interval(5), causing a new health check to be scheduled before probes for the existing one complete.fix: use default healthcheck interval 1s, giving time for probes to be performed
Note
Low Risk
Low risk: test-only change that adjusts health check config to avoid overlapping scheduled runs and reduce timing-related flakiness.
Overview
Updates
HealthCheckTest.testPolicy_AllSuccess_StopsOnFirstFailureto stop overridinginterval/timeoutin the strategy config, relying on defaults so the probe sequence completes before a new scheduled health check can start.This stabilizes the assertion that
BuiltIn.ALL_SUCCESSstops after the first failed probe by removing timing-sensitive scheduling behavior from the test.Reviewed by Cursor Bugbot for commit 1784c7b. Bugbot is set up for automated code reviews on this repo. Configure here.