[uglide]

Note

Medium Risk
Touches protocol selection/negotiation paths across Jedis, pipelines, transactions, and cluster pipeline, which can affect reply decoding and compatibility when protocol is unspecified or negotiation fails. Changes are small but impact core client behavior and are best validated against both RESP2/RESP3 servers.

Overview
Enforces a concrete RESP protocol for CommandObjects and removes reliance on null as a protocol sentinel. CommandObjects now throws if constructed with null, and callers (Jedis, Pipeline, Transaction, ReliableTransaction, UnifiedJedis, ClusterPipeline) consistently use RedisProtocol.orServerDefault(...) to fall back to the server default (RESP2) when no protocol is resolved.

Updates a few command reply parsers (hrandfieldWithValues, jsonType) to branch explicitly on RESP2 vs non-RESP2 rather than non-RESP3, and adjusts tests to stop parameterizing CommandObjects tests with a null protocol.

^{Reviewed by Cursor Bugbot for commit 9006db1. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

Test Results

  195 files  ±  0    195 suites  ±0   9m 34s ⏱️ -28s
7 307 tests  - 459  7 084 ✅  - 447  223 💤  - 12  0 ❌ ±0 
7 327 runs   - 459  7 104 ✅  - 447  223 💤  - 12  0 ❌ ±0 

Results for commit 9006db1. ± Comparison against base commit 49ac82c.

This pull request removes 459 tests.

redis.clients.jedis.commands.commandobjects.CommandObjectsBitmapCommandsTest[3] ‑ testBitcount()[3]
redis.clients.jedis.commands.commandobjects.CommandObjectsBitmapCommandsTest[3] ‑ testBitfield()[3]
redis.clients.jedis.commands.commandobjects.CommandObjectsBitmapCommandsTest[3] ‑ testBitfieldBinary()[3]
redis.clients.jedis.commands.commandobjects.CommandObjectsBitmapCommandsTest[3] ‑ testBitop()[3]
redis.clients.jedis.commands.commandobjects.CommandObjectsBitmapCommandsTest[3] ‑ testBitopBinary()[3]
redis.clients.jedis.commands.commandobjects.CommandObjectsBitmapCommandsTest[3] ‑ testBitpos()[3]
redis.clients.jedis.commands.commandobjects.CommandObjectsBitmapCommandsTest[3] ‑ testSetbitAndGetbit()[3]
redis.clients.jedis.commands.commandobjects.CommandObjectsBitmapCommandsTest[3] ‑ testSetbitAndGetbitBinary()[3]
redis.clients.jedis.commands.commandobjects.CommandObjectsBloomFilterCommandsTest[3] ‑ testBfAddAndExists()[3]
redis.clients.jedis.commands.commandobjects.CommandObjectsBloomFilterCommandsTest[3] ‑ testBfInfo()[3]
…

This pull request skips 8 tests.

redis.clients.jedis.commands.commandobjects.CommandObjectsJsonCommandsTest[2] ‑ testJsonArrLenRoot()[2]
redis.clients.jedis.commands.commandobjects.CommandObjectsJsonCommandsTest[2] ‑ testJsonDebugMemoryRoot()[2]
redis.clients.jedis.commands.commandobjects.CommandObjectsJsonCommandsTest[2] ‑ testJsonGetWithClass()[2]
redis.clients.jedis.commands.commandobjects.CommandObjectsJsonCommandsTest[2] ‑ testJsonObjKeysRoot()[2]
redis.clients.jedis.commands.commandobjects.CommandObjectsJsonCommandsTest[2] ‑ testJsonObjLenRoot()[2]
redis.clients.jedis.commands.commandobjects.CommandObjectsJsonCommandsTest[2] ‑ testJsonStrAppendRootPath()[2]
redis.clients.jedis.commands.commandobjects.CommandObjectsJsonCommandsTest[2] ‑ testJsonStrLenRootPath()[2]
redis.clients.jedis.commands.commandobjects.CommandObjectsJsonCommandsTest[2] ‑ testJsonTypeOldPath()[2]

♻️ This comment has been updated with latest results.

[jit-ci]

🛡️ Jit Security Scan Results

✅ No security findings were detected in this PR

---

^{Security scan by Jit}

[atakavci]

LGTM
(went through only the changes against part2)

[atakavci]

many test case impacted;
java.lang.IllegalArgumentException: protocol must not be null

[ggivo]

LGTM