Skip to content

Verify that RADIX_TREE_KEYS and RADIX_TREE_NODES were parsed - #4573

Merged
uglide merged 1 commit into
masterfrom
im/do-not-verify-internal-fields-in-xinfo
Jun 25, 2026
Merged

uglide merged 1 commit into
masterfrom
im/do-not-verify-internal-fields-in-xinfo

Conversation

@uglide

@uglide uglide commented Jun 24, 2026 •

Copy link
Copy Markdown
Contributor

Note

Low Risk
Test-only changes with no production code impact.

Overview
Extends XINFO STREAM integration coverage so radix-tree-keys and radix-tree-nodes from Redis are verified as parsed Long values, without asserting specific numbers (they are internal debug fields).

The same checks are added in StreamsCommandsTest and StreamsPipelineCommandsTest for StreamInfo (map keys and getRadixTreeKeys() / getRadixTreeNodes()) and for StreamFullInfo from XINFO STREAM FULL.

Reviewed by Cursor Bugbot for commit 47c47d5. Bugbot is set up for automated code reviews on this repo. Configure here.

@jit-ci

jit-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

πŸ›‘οΈ Jit Security Scan Results

CRITICAL HIGH MEDIUM

βœ… No security findings were detected in this PR


Security scan by Jit

@github-actions

github-actions Bot commented Jun 24, 2026 •

Copy link
Copy Markdown

Test Results

β€‡β€ˆ203 files  Β±0β€‚β€ƒβ€‡β€ˆ203 suites  Β±0   10m 6s ⏱️ +23s
7β€ˆ771 tests Β±0  7β€ˆ705 βœ… +597  66 πŸ’€  -β€Š597  0 ❌ Β±0 
7β€ˆ791 runsβ€Š Β±0  7β€ˆ725 βœ… +597  66 πŸ’€  -β€Š597  0 ❌ Β±0 

Results for commit 47c47d5. ± Comparison against base commit c72f02c.

♻️ This comment has been updated with latest results.

@ggivo ggivo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uglide
uglide merged commit f46de70 into master Jun 25, 2026
18 of 19 checks passed
ggivo added a commit that referenced this pull request Jun 26, 2026
* Do not assert on internal field of XINFO command (#4571)

(cherry picked from commit c72f02c)

* Verify that RADIX_TREE_KEYS and RADIX_TREE_NODES were parsed (#4573)

(cherry picked from commit f46de70)

---------

Co-authored-by: Igor Malinovskiy <u.glide@gmail.com>
@ggivo ggivo added this to the 8.0.0 milestone Aug 7, 2026
@ggivo
ggivo deleted the im/do-not-verify-internal-fields-in-xinfo branch September 30, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants