Repository navigation
Remove unusable aclLogBinary() methods - #4580
Merged
Merged
Conversation
The List<byte[]> return type cannot represent the ACL LOG reply (a nested array of entries), so element access always threw ClassCastException. aclLog() already exposes the same data as structured AccessControlLogEntry objects.
uglide
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Jedis.aclLogBinary()/aclLogBinary(int)(declared onAccessControlLogBinaryCommands) declareList<byte[]>, but theACL LOGreply is a nested array (Array<Array<...>>) β a list of entries, each itself a flattened list of key/value pairs.getBinaryMultiBulkReply()only does an unchecked(List<byte[]>)cast, so the elements are actually nested lists. Reading any element throwsClassCastException: java.util.ArrayList cannot be cast to [B. The methods have never been usable.Fixes #4579.
Change
aclLogBinary()andaclLogBinary(int)fromJedisandAccessControlLogBinaryCommands.ACLTestUtil.filterBinaryByClientIdand its usage inAccessControlListCommandsTest.Migration
Use
aclLog()/aclLog(int), which return structuredAccessControlLogEntryobjects for the same data.Note
Low Risk
Small API deletion of methods that were never usable; migration path to existing
aclLog()APIs is straightforward.Overview
Removes
aclLogBinary()andaclLogBinary(int)fromJedisandAccessControlLogBinaryCommands. Those APIs claimedList<byte[]>but could not parse the nestedACL LOGreply, so they threwClassCastExceptionat runtime.Callers should use
aclLog()/aclLog(int), which returnAccessControlLogEntryobjects. The v7βv8 migration guide adds a breaking-change section for this removal. Tests drop binary ACL log coverage and the test-onlyACLTestUtil.filterBinaryByClientIdhelper.Reviewed by Cursor Bugbot for commit c190541. Bugbot is set up for automated code reviews on this repo. Configure here.