Repository navigation
[Redis 8.10] Add integration test for search-on-timeout config - #4600
Conversation
Test Resultsββ206 filesβ Β±β0ββββ206 suitesβ Β±0βββ8m 8s β±οΈ +31s Results for commit 7d2e603.βΒ± Comparison against base commit 87e9df2. β»οΈ This comment has been updated with latest results. |
351da5e to
0e3ec43
Compare
ggivo
left a comment
There was a problem hiding this comment.
Tests LGTM,
We should be good to go without the utility to wait for the index update, similar to other tests in the suite.
New tests are currently ignored since the assumption about the required module version is still not met in the 8.10 environment.Tested locally with client-libs-test:8.10-m01-int / search_80800
Need to verify the required search module version, to ensure test actualy get executed
38fb48c to
800fc1f
Compare
|
@ggivo proof that we need index size assertions https://github.com/redis/jedis/actions/runs/30371674153/job/90316840213?pr=4600#step:3:17039 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
β Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a9e53c6. Configure here.
0200464 to
fc933ee
Compare

Note
Low Risk
Test-only and docker-compose changes; no production Jedis API or runtime behavior is modified.
Overview
Adds integration coverage for RediSearch
search-on-timeout(CAE-3003): withCONFIG SET search-on-timeoutapplied cluster-wide, tests assert FAIL surfaces aJedisDataExceptionmentioning timeout and RETURN leaves warnings onSearchResult/AggregationResult(RESP3 for FT.SEARCH/AGGREGATE). Heavy 10k-doc indexes and 1ms query timeouts are used to force the policy to trigger.FT.HYBRID equivalents are added in
FTHybridCommandsTestBasebut@Disableduntil MOD-17316 is fixed.Test support: new
AssertUtil.assertIndexSize(pollFT.INFOuntilnum_docsmatches),SEARCH_MOD_VER_810M3inRedisConditions, andcluster-stablecluster-node-timeoutraised to 5000 in docker-compose to reduce flaky CLUSTERDOWN during bulk loads.Reviewed by Cursor Bugbot for commit 7d2e603. Bugbot is set up for automated code reviews on this repo. Configure here.