Skip to content

[Redis 8.10] Add integration test for search-on-timeout config - #4600

Merged
uglide merged 4 commits into
masterfrom
im/search-timeout
Jul 31, 2026
Merged

uglide merged 4 commits into
masterfrom
im/search-timeout

Conversation

@uglide

@uglide uglide commented Jul 8, 2026 •

Copy link
Copy Markdown
Contributor

Note

Low Risk
Test-only and docker-compose changes; no production Jedis API or runtime behavior is modified.

Overview
Adds integration coverage for RediSearch search-on-timeout (CAE-3003): with CONFIG SET search-on-timeout applied cluster-wide, tests assert FAIL surfaces a JedisDataException mentioning timeout and RETURN leaves warnings on SearchResult / AggregationResult (RESP3 for FT.SEARCH/AGGREGATE). Heavy 10k-doc indexes and 1ms query timeouts are used to force the policy to trigger.

FT.HYBRID equivalents are added in FTHybridCommandsTestBase but @Disabled until MOD-17316 is fixed.

Test support: new AssertUtil.assertIndexSize (poll FT.INFO until num_docs matches), SEARCH_MOD_VER_810M3 in RedisConditions, and cluster-stable cluster-node-timeout raised to 5000 in docker-compose to reduce flaky CLUSTERDOWN during bulk loads.

Reviewed by Cursor Bugbot for commit 7d2e603. Bugbot is set up for automated code reviews on this repo. Configure here.

@uglide
uglide requested a review from ggivo July 8, 2026 14:41
@github-actions

github-actions Bot commented Jul 8, 2026 •

Copy link
Copy Markdown

Test Results

β€‡β€ˆ206 files  ± 0β€‚β€ƒβ€‡β€ˆ206 suites  Β±0   8m 8s ⏱️ +31s
8β€ˆ068 tests +24  8β€ˆ000 βœ… +937  68 πŸ’€  -β€Š913  0 ❌ Β±0 
8β€ˆ088 runsβ€Š +24  8β€ˆ020 βœ… +939  68 πŸ’€  -β€Š915  0 ❌ Β±0 

Results for commit 7d2e603. ± Comparison against base commit 87e9df2.

♻️ This comment has been updated with latest results.

Comment thread src/test/resources/env/.env.v8.10 Resolved
@uglide
uglide force-pushed the im/search-timeout branch from 351da5e to 0e3ec43 Compare July 10, 2026 15:11

@ggivo ggivo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM,

We should be good to go without the utility to wait for the index update, similar to other tests in the suite.

New tests are currently ignored since the assumption about the required module version is still not met in the 8.10 environment.Tested locally with client-libs-test:8.10-m01-int / search_80800

Need to verify the required search module version, to ensure test actualy get executed

@uglide
uglide force-pushed the im/search-timeout branch from 38fb48c to 800fc1f Compare July 17, 2026 15:27
@ggivo ggivo added this to the 8.0.0 milestone Jul 28, 2026
@ggivo ggivo added the testing label Jul 28, 2026
@uglide

uglide commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a9e53c6. Configure here.

@uglide
uglide force-pushed the im/search-timeout branch from 0200464 to fc933ee Compare July 29, 2026 16:40
@uglide
uglide merged commit aaf15e8 into master Jul 31, 2026
13 of 16 checks passed
@uglide
uglide deleted the im/search-timeout branch July 31, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants