Repository navigation
[Redis 8.10] Add LMVOVEM/BLMOVEM commands - #4635
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 38c46da. Configure here.
4 tasks
ggivo
reviewed
Jul 22, 2026
| @Test | ||
| @EnabledOnCommand("LMOVEM") | ||
| @ConditionalOnEnv(value = TestEnvUtil.ENV_REDIS_ENTERPRISE, enabled = false) | ||
| public void lmovem() { |
Collaborator
There was a problem hiding this comment.
any reason not to follow same test scenariou from UnifiedJedis absed tests in ListCommandsTestBase
| @Test | ||
| @EnabledOnCommand("BLMOVEM") | ||
| @ConditionalOnEnv(value = TestEnvUtil.ENV_REDIS_ENTERPRISE, enabled = false) | ||
| public void blmovem() { |
Collaborator
There was a problem hiding this comment.
any reason not to follow same test scenariou from UnifiedJedis absed tests in ListCommandsTestBase
The aggregate lmovem/blmovem tests mixed the four public overloads, so a failure did not identify the API at fault and the no-params blocking overload had no coverage at all. One test per overload, extended with a satisfiable EXACTLY case and missing-source checks; cluster overrides split to match.
Hardcoded key names on the shared test endpoints can collide across suites; the registry namespaces them per test and deletes them in teardown instead of relying on the blanket flush. Cluster overrides hash-tag the per-test prefix so source and destination stay in one slot.
# Conflicts: # pom.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4637
Note
Low Risk
Additive API mirroring existing LMOVE/BLMOVE patterns; behavior depends on Redis 8.10+ server support and is covered by broad tests.
Overview
Adds client support for Redis LMOVEM and BLMOVEM, which atomically move one or more list elements between keys and return them as a list (unlike LMOVE, which returns a single value).
New types
LMoveMParams(optionalCOUNT/EXACTLYplusOBOorBULKordering viaListMoveOrder) and protocol keywordEXACTLYwire the multi-element move block.lmovem/blmovemare exposed for string and binary keys acrossJedis,UnifiedJedis, pipelines, and list command interfaces, with integration, cluster, mocked, and unit tests.Reviewed by Cursor Bugbot for commit fb826ac. Bugbot is set up for automated code reviews on this repo. Configure here.