Repository navigation
Add missing plain overloads for experimental vector-set commands - #4693
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfc526490f
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Thanks for the PR! I'll try to take a look once I get some free cycles. Heads up β I'm on vacation starting next week, so the review may take a bit longer. |
14fc8c4 to
36d68b5
Compare
Vector-set methods with REDUCE or WITHSCORES had no no-params overload, so callers had to pass null. Add the additive overloads requested in redis#4688 on command, binary, and pipeline surfaces. Null-tolerance removal is left for a follow-up.
36d68b5 to
eafb853
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddea610b48
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0eb90c6fff
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7005fd2922
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4652f0ec2f
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1b4d8b78d
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Vector-set methods with REDUCE or WITHSCORES had no no-params overload, so callers had to pass null. Add the additive overloads requested in redis#4688 on command, binary, and pipeline surfaces. Null-tolerance removal is left for a follow-up.
β¦tor-set-plain-overloads
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3314842933
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Remove @experimental from implementations; the interface methods already carry it - Move the release-notes entry out of Highlights into API Additions - Test the plain overloads against the server in the IT base, not in a unit test - Delegate the new plain overloads with empty params instead of null - Delegate the existing plain overloads with empty params so redis#4688 becomes a pure removal
Summary
Experimental vector-set methods that take
reduceDimor return scores currently have no no-params overload, so callers have to passnull. The rest of Jedis models optional params as a plain method plus a params-taking one.This is the additive part of #4688:
vadd/vaddFP32withreduceDimand no paramsvsimWithScores/vsimByElementWithScoreswith no paramsvsimWithScoresAndAttribs/vsimByElementWithScoresAndAttribswith no params (command surfaces only; pipeline does not have those variants)Plain overloads encode the same argv as the existing params overload with
null. Null-tolerance removal is left for a follow-up.Test plan
mvn -Dtest=VectorSetPlainOverloadsTest test(12/12)mvn -DskipTests compile test-compilemvn formatter:validateNote
Low Risk
Additive API on experimental vector-set commands; behavior matches prior null-param calls with no breaking signature changes.
Overview
Adds parameter-free overloads for experimental vector-set commands so callers no longer need to pass
nullfor optionalVAddParams/VSimParams.New public methods cover
vadd/vaddFP32withreduceDim, andvsim*WithScores/vsim*WithScoresAndAttribs(by vector and by element), for String and binary keys/elements. The same surface is wired throughCommandObjects,Jedis,UnifiedJedis, command interfaces, andPipeliningBase(including pipeline interfaces that were missingvsim*WithScoresAndAttribs).Existing no-params delegators in
CommandObjectsnow forward withnew VAddParams()/new VSimParams()instead ofnull. Integration tests use the new overloads; a mocked pipeline test class was added and documented in 8.1.0 release notes.Reviewed by Cursor Bugbot for commit 9cf3815. Bugbot is set up for automated code reviews on this repo. Configure here.