You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Cacheable key collision with DefaultKeyGenerator [SPR-10237]Â #14870
The default is to use the hashcode of each parameter and create another (32-bit) hash code. Obviously this can easily generate collisions. This should be clearly documented as it feels like a pretty serious issue, if not a bug. We have come to expect that Spring defaults are "safe" :-)
Spring 4.0 will now use the SimpleKeyGenerator class to generate cache keys if no specific KeyGenerator is configured. The DefaultKeyGenerator remains available for applications that do not wish to migrate.
I have stopped sort of including the target object or method name inside the key (as suggested in #13675). The primary reason for this is that the same key needs to be generated for @Cacheable, @CachePut and @CacheEvict annotated method, which will most likely be on different methods and potentially different beans.
For any method with a single non-null parameter, the result of SimpleKeyGenerator is identical to DefaultKeyGenerator. In other cases it is possible that the SimpleKey type might not be compatible with all Cache implementations. Given the number of times that this bug has been raised I think this restriction is acceptable, however, since this is a potentially breaking change I do not intend to back-port to 3.2.x
Activity
spring-projects-issues commentedon Feb 1, 2013
Tomasz Nurkiewicz commented
Looks like a duplicate of #13675 and #14013.
spring-projects-issues commentedon Jun 21, 2013
Phil Webb commented
Spring 4.0 will now use the
SimpleKeyGeneratorclass to generate cache keys if no specificKeyGeneratoris configured. TheDefaultKeyGeneratorremains available for applications that do not wish to migrate.I have stopped sort of including the target object or method name inside the key (as suggested in #13675). The primary reason for this is that the same key needs to be generated for
@Cacheable,@CachePutand@CacheEvictannotated method, which will most likely be on different methods and potentially different beans.For any method with a single non-null parameter, the result of
SimpleKeyGeneratoris identical toDefaultKeyGenerator. In other cases it is possible that theSimpleKeytype might not be compatible with allCacheimplementations. Given the number of times that this bug has been raised I think this restriction is acceptable, however, since this is a potentially breaking change I do not intend to back-port to 3.2.x