Repository navigation
Prevent unquoting of query string reserved characters - #60
Merged
Merged
Conversation
Owner
|
sorry for the delay. this is good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59.
In
amz_cano_querystring:unquote/quotesteps to prevent the introduction of quoted reservered charactersparse_qs(AWS doesn't consider them a delimiter and this was previously handled by thequotestep)This breaks the
post-vanilla-query-nonunreservedtest in aws_testsuite becauseresponsesauto-quotes the URL, so intest_requests_aws4auth.py:unquote/quotesteps temporarily undid the quoting)Added test cases to cover this issue. All tests pass. including the live tests (for the endpoints that still exist).