joysound.com: nuisance

URL(s) where the issue occurs

https://www.joysound.com/web/search/song/746956

Describe the issue

Annoyances: context menu, copy, and text-selection disabled

Screenshot(s)

Versions

Browser/version: 1.8.90
uBlock Origin version: 1.26.0

Settings

Default + uBlock Annoyances

Notes

As style overriding didn't work, I added

joysound.com##+js(set, document.body.oncopy, null)
joysound.com##+js(set, document.body.onselectstart, null)
joysound.com##+js(set, document.body.oncontextmenu, null)

as set by https://www.joysound.com/web/feature/search/js/songdetail.min.js, then the page hid the lyrics:

set sets the value in early which is causing site breakage(document.body gets set to null as per dev-tools). You will need an event based setter/getter scriptlet or do it manually by copy-pasting in the console after page-load --

document.body.oncontextmenu = document.body.onselectstart = document.body.oncopy = null;

@gorhill

@gorhill

I could prevent the context menu from being disable with:

joysound.com##+js(aopr, document.body.oncontextmenu)

However, the same approach did not work for the selection.

The reason is how the aopr scriptlet is written and I think this can be overcome with the same fix I did here.

Edit: actually set would also work using the same fix.

joysound.com##+js(aopr, document.body.oncontextmenu)

doesn't it break anything ?

joysound.com##+js(aopr, document.body.oncontextmenu) does not work either, it breaks the "pretender" section (see the pic above)

Oh I see, I need to investigate more then -- though it wouldn't hurt to ensure that set and aopr are reentrant-resistant.

Ok, document.body is special, though the scriptlet traps the property to detect when its value changes, the browser is modifying its value internally, bypassing the trap.

https://github.com/NanoAdblocker/NanoFilters/blob/master/NanoFiltersSource/NanoResources.txt#L27 will work for this case.

Right... This kind of lead me back to the idea of simple operators which can be chained, in such case it would be to merely add a match-readystate operator and thus all scriptlet operators which would follow would be executed after the target ready state is reached, without keeping duplicating code.

+js:match-readystate(/interactive|complete/):set-constant(document.body.oncontextmenu, null)

That would be much better ofcourse and without having to resort to adding another scriptlet, also you can shorten :match-readystate to just :readystate as we don't have any such existing operator.

It seems gorhill likes to keep words match/watch as a first part of the name (matches-css, matches-css-before, matches-css-after, watch-attr) for procedural operators, perhaps that will applied to scriplets as well, so I'm curious, following this logic: :watch-attributes ==> :watch-attrs ==> :watch-attr
we get___________________________________:match-readystate ==> :match-ready ==> :match-rdy

I guess found another case.
[NSFW] https://www.j-live.tv/

document.body.oncopy
#12528

This issue should be fixed with the last improvement of set-constant scriptlet

Add ability to defer set-constant execution
A new optional parameter has been added to `set-constant`
scriptlet: `runAt`, default to `0`.

 ..##+js(set, document.body.oncontextmenu, null, 2)

When the `runAt` parameter is present, uBO will take it into
account to possibly defer execution of `set-constant`:

- `runAt` not present: execute immediately
- `runAt` = 1: execute immediately
- `runAt` = 2: execute when document state is "interactive"
- `runAt` = 3: execute when document state is `"complete"

Tested in firefox, uBO 1.48.9b1

(sometimes I need more than 1 refresh)

joysound.com##+js(set, document.body.oncopy, null, 3)
joysound.com##+js(set, document.body.onselectstart, null, 3)
joysound.com##+js(set, document.body.oncontextmenu, null, 3)
joysound.com##body:style(-webkit-touch-callout: default !important; -webkit-user-select: text !important; -moz-user-select: text !important; -ms-user-select: text !important; user-select: text !important;)
joysound.com##style:has-text(@media print):remove()

This issue should be fixed with the last improvement of set-constant scriptlet

I used the case here to test but it didn't fix it on my side (at least in Chromium). There is this weird state in the DOM where document.body.oncontextmenu is null, but the event listener that was assigned to it is still executed by the browser.

maybe it's why even in firefox the right-click is still disabled but upon refreshing the page it will finally work

@gorhill

@gorhill

adding this filter makes right click works in chrome on my end

joysound.com##+js(aeld, DOMContentLoaded, ready)

Nice, so the extra parameter was indeed required to solve this issue.

@Yuki2718

@Yuki2718 Are you satisified that the following filters (using dev build) are taking care of the issue?

joysound.com##+js(set, document.body.oncopy, null, 3)
joysound.com##+js(set, document.body.onselectstart, null, 3)
joysound.com##+js(set, document.body.oncontextmenu, null, 3)
joysound.com##+js(aeld, DOMContentLoaded, ready)
joysound.com##body:style(user-select: unset !important)

Yes, they're working fine, thx!

I am going to change the last parameter to make the purpose more clear, and to align the values with already existing documentation out there. So it will be:

end or interactive: at DOMContentLoaded event time
idle or complete: at load event time

Anything else will be "as soon as possible".

To be clear, end and idle are documented in extensions API, interactive and complete are documented in Web API. Using number would be more difficult to remember and thus inconvenient as filter list maintainer.

So for future filters that need runAt parameter, we will need to write in JSON format, is it correct?

Depends of the scriptlet. For set-constant, the positional form is available; for aeld, only with the JSON notation.

Got it

Navigation Menu

Repository navigation

joysound.com: nuisance #7320

URL(s) where the issue occurs

Describe the issue

Screenshot(s)

Versions

Settings

Notes

2 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

joysound.com: nuisance #7320

Description

URL(s) where the issue occurs

Describe the issue

Screenshot(s)

Versions

Settings

Notes

Activity

uBlock-user commented on May 7, 2020

mapx- commented on May 7, 2020

gorhill commented on May 7, 2020

uBlock-user commented on May 7, 2020

mapx- commented on May 7, 2020

gorhill commented on May 7, 2020

gorhill commented on May 7, 2020

uBlock-user commented on May 7, 2020

gorhill commented on May 7, 2020

uBlock-user commented on May 7, 2020

kulfoon commented on May 10, 2020

Yuki2718 commented on May 29, 2020

Yuki2718 commented on Jul 25, 2021

2 remaining items

mapx- commented on Apr 1, 2022

mapx- commented on Apr 13, 2023

gorhill commented on Apr 13, 2023

mapx- commented on Apr 13, 2023

mapx- commented on Apr 15, 2023

gorhill commented on Apr 15, 2023

gorhill commented on Apr 16, 2023

Yuki2718 commented on Apr 19, 2023

gorhill commented on Apr 27, 2023

stephenhawk8054 commented on Apr 28, 2023

gorhill commented on Apr 28, 2023

stephenhawk8054 commented on Apr 28, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions