bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ansic*: reduce multibyte function calls


From: Grisha Levit
Subject: Re: [PATCH] ansic*: reduce multibyte function calls
Date: Mon, 27 Oct 2025 13:00:18 -0400

On Wed, Oct 22, 2025, 16:44 Chet Ramey <chet.ramey@case.edu> wrote:
>
> On 10/22/25 1:41 PM, Grisha Levit wrote:
> > In the ansic* functions, if HANDLE_MULTIBYTE is defined, we end up
> > calling mbrtowc for non-"basic" characters in singlebyte locales.
> > While this is not incorrect (Android's broken implementation aside),
> > we can optimize by being more selective about when to call mbrtowc.
>
> Thanks for the patch.

Thanks for applying. The new version [1] still has `mb_cur_max > 0'
in ansicstr; that should be '> 1`, no?

[1] https://git.gnu.org/cgit/bash.git/diff/lib/sh/strtrans.c?id=c299f535



reply via email to

[Prev in Thread] Current Thread [Next in Thread]