|
| From: | Chet Ramey |
| Subject: | Re: [PATCH] ansic*: reduce multibyte function calls |
| Date: | Mon, 27 Oct 2025 14:36:34 -0400 |
| User-agent: | Mozilla Thunderbird |
On 10/27/25 1:00 PM, Grisha Levit wrote:
On Wed, Oct 22, 2025, 16:44 Chet Ramey <chet.ramey@case.edu> wrote:On 10/22/25 1:41 PM, Grisha Levit wrote:In the ansic* functions, if HANDLE_MULTIBYTE is defined, we end up calling mbrtowc for non-"basic" characters in singlebyte locales. While this is not incorrect (Android's broken implementation aside), we can optimize by being more selective about when to call mbrtowc.Thanks for the patch.Thanks for applying. The new version [1] still has `mb_cur_max > 0' in ansicstr; that should be '> 1`, no?
Good catch, thanks.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU chet@case.edu http://tiswww.cwru.edu/~chet/
OpenPGP_signature.asc
Description: OpenPGP digital signature
| [Prev in Thread] | Current Thread | [Next in Thread] |