coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: date: add tests for the Thai solar calendar


From: Collin Funk
Subject: Re: date: add tests for the Thai solar calendar
Date: Mon, 21 Jul 2025 21:35:59 -0700
User-agent: Gnus/5.13 (Gnus v5.13)

Hi Pádraig,

Pádraig Brady <P@draigBrady.com> writes:

> Right, though it might be better to use \uXXXX char specifiers
> than raw UTF-8 encodings. Something like:
>
> # All months that have 31 days have names that end with "คม".
> days_31_suffix=$(env LC_ALL=th_TH.UTF-8 printf '\u0E04\u0E21')
> test $(printf '%s' "$days_31_suffix" | wc -c) = 6 || skip_ 'bad suffix'
> for month in 01 03 05 07 08 10 12; do
>   date --date=$current_year-$month-01 +%B | grep "$days_31_suffix$" || fail=1
> done

Thanks, that looks good to me.

> Sorry for the tardy response. I was on holidays.

No problem at all.

> But you can just use the explicit charmap, like:
>
>  $ LC_ALL=th_TH.UTF-8 locale charmap
>  UTF-8
>  $ LC_ALL=am_ET.UTF-8 locale charmap
>  UTF-8

Cool, sounds good.

I pushed this patch with the removal of the "==" bashism, your printf
recommendation, and the locale check. Plus I added two checks that test
the behavior of Bruno's patch, that --iso-8601 and --rfc-3339 use the
Gregorian calendar in the Thai locale.

> thanks for working on this

No problem, thanks to you and Berny for checking. I'll write tests for
the other two locales tomorrow.

Collin

Attachment: 0001-tests-date-add-tests-for-the-Thai-solar-calendar.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]