coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GitHub patches


From: Collin Funk
Subject: Re: GitHub patches
Date: Thu, 18 Jun 2026 21:23:43 -0700
User-agent: Gnus/5.13 (Gnus v5.13)

Sam James <sam@gentoo.org> writes:

> I was going to make a comment on a recent commit
> (bd649cca23f30646a3856b47cd1c7afd1aeb6db3) but found there was no mail
> on the coreutils ML for me to reply to.
>
> PƔdraig, WDYT about perhaps git-send-email'ing patches merged from
> GitHub? I don't want to put work onto you though and I'm only an
> occasional writer on the coreutils ML, so I already feel a little bad
> asking.

It sounds like a good idea to me. I kind-of review the GitHub PRs as
well, though not as much as PƔdraig, but still prefer email.

I was going to suggest automating it somehow, but I suppose there is no
way to differentiate between normal patches and ones from GitHub.

We could have all commits sent to the mailing list, e.g., like
emacs-diffs@gnu.org [1]. However, I do like submitting non-trivial
patches to the list for review before pushing. That would lead to the
same patch being sent twice on-list, which would probably become
annoying.

Collin

[1] https://lists.gnu.org/archive/html/emacs-diffs/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]