coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GitHub patches


From: Pádraig Brady
Subject: Re: GitHub patches
Date: Fri, 19 Jun 2026 15:48:43 +0100
User-agent: Mozilla Thunderbird Beta

On 19/06/2026 05:23, Collin Funk wrote:
Sam James <sam@gentoo.org> writes:

I was going to make a comment on a recent commit
(bd649cca23f30646a3856b47cd1c7afd1aeb6db3) but found there was no mail
on the coreutils ML for me to reply to.

I've just sent this email to the list for discussion.
Note the diff does have the github PR discussion link
in the commit message, if you wanted to comment there.

Pádraig, WDYT about perhaps git-send-email'ing patches merged from
GitHub? I don't want to put work onto you though and I'm only an
occasional writer on the coreutils ML, so I already feel a little bad
asking.

It sounds like a good idea to me. I kind-of review the GitHub PRs as
well, though not as much as Pádraig, but still prefer email.

I was going to suggest automating it somehow, but I suppose there is no
way to differentiate between normal patches and ones from GitHub.

We could have all commits sent to the mailing list, e.g., like
emacs-diffs@gnu.org [1]. However, I do like submitting non-trivial
patches to the list for review before pushing. That would lead to the
same patch being sent twice on-list, which would probably become
annoying.

Collin

[1] https://lists.gnu.org/archive/html/emacs-diffs/

Automated emails are awkward for various spam protection reasons.
Anyway it's best to have some manual control to avoid
overwhelming the lists. I was err'ing on the side of
not sending already discussed PRs (on github) to this list,
but will err more on the side of sending the email when pushing.

BTW I use the attached script for pulling down a PR locally for
review/adjustment before pushing, as merging on github is ineffective
since we've only a mirror on github at present.

cheers,
Padraig

Attachment: apply-pr
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]