Re: [PATCH] cp, mv: do preserve extended attributes even for read-only s
From:
Pádraig Brady
Subject:
Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files
Date:
Mon, 7 Sep 2009 12:03:02 +0100
User-agent:
Thunderbird 2.0.0.6 (X11/20071008)
Ondřej Vašík wrote:
> Pádraig Brady wrote:
>> To minimize side affects perhaps we should only do the chmod(600)
>> if (geteuid () != 0 && !access (src_name, W_OK)) ?
>
> Good idea, it would reduce possibility of security leak, playing with
> access rights is always a bit dangerous (although here we play with
> rights on destination descriptor, which is imho much more safe).
>
> Additionally - Jim is correct that for different owner 0600 rights are
> not sufficient for different owner of the file - and 0666 is too much
> devil-like ;) . Any idea?
preserve_xattr before preserve_ownership ?
cheers,
Pádraig.