Re: [PATCH] cp, mv: do preserve extended attributes even for read-only s
From:
Ondřej Vašík
Subject:
Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files
Date:
Mon, 07 Sep 2009 14:56:35 +0200
Pádraig Brady wrote:
> Ondřej Vašík wrote:
> > Pádraig Brady wrote:
> >> To minimize side affects perhaps we should only do the chmod(600)
> >> if (geteuid () != 0 && !access (src_name, W_OK)) ?
> >
> > Good idea, it would reduce possibility of security leak, playing with
> > access rights is always a bit dangerous (although here we play with
> > rights on destination descriptor, which is imho much more safe).
> >
> > Additionally - Jim is correct that for different owner 0600 rights are
> > not sufficient for different owner of the file - and 0666 is too much
> > devil-like ;) . Any idea?
>
> preserve_xattr before preserve_ownership ?
Good idea, moved there and used that (geteuid () != 0 && access
(src_name, W_OK)) construction - additionally I tried to reduce those
chmod calls (call for returning permissions only when the write_access
granting call was used) - so it should be safer now.
Anyway, added comment that real problem is in libattr and this is just
workaround and added FIXME. Better now?
Greetings,
Ondřej